From c692d78080dc503e795345e6c48a753da10ae153 Mon Sep 17 00:00:00 2001
From: Arno <arno@disconnect.de>
Date: Fri, 7 Jul 2017 17:18:07 +0200
Subject: Improve MusicBrainz search

Don't display crap when we don't have a match. Show alternative artists
instead, or nothing...
---
 playerwidget.cpp | 41 +++++++++++++++++++++++++++--------------
 1 file changed, 27 insertions(+), 14 deletions(-)

(limited to 'playerwidget.cpp')

diff --git a/playerwidget.cpp b/playerwidget.cpp
index 54c2cca..0810487 100644
--- a/playerwidget.cpp
+++ b/playerwidget.cpp
@@ -1265,22 +1265,35 @@ void PlayerWidget::searchMusicbrainzLeft(){
 
 
 void PlayerWidget::webDlDone(){
-    QString text(tr("<b>Musicbrainz:</b><table style=\"margin-bottom: 20px\">"));
     QString aId = mWebDownloader->artistId();
-    text.append(QString(tr("<tr><td style=\"padding-left: 30px\">Artist</td><td style=\"padding-left: 30px\"><a href=\"https://musicbrainz.org/artist/%1\">%2</a></td></tr>")).arg(aId).arg(mWebDownloader->artist()));
-    foreach(QString alId, mWebDownloader->data()){
-        text.append(QString("<tr><td style=\"padding-left: 30px\">Album</td><td style=\"padding-left: 30px\"><a href=\"https://musicbrainz.org/release-group/%1\">%2</a></td></tr>").arg(alId).arg(mWebDownloader->album()));
-    }
-    text.append("</table>");
-    const QMap<QString, QString> other = mWebDownloader->otherData();
-    text.append(QString(tr("<b>All Albums (%1):</b><ul>")).arg(QString::number(other.count())));
-    QStringList albums = other.values();
-    std::sort(albums.begin(), albums.end());
-    foreach(QString a, albums){
-        QString id = other.key(a);
-        text.append(QString("<li><a href=\"https://musicbrainz.org/release-group/%1\">%2</a></li>").arg(id).arg(a));
+    QString text;
+    if(!aId.isEmpty()){
+        text.append(QString(tr("<b>Musicbrainz:</b><table style=\"margin-bottom: 20px\">")));
+        text.append(QString(tr("<tr><td style=\"padding-left: 30px\">Artist</td><td style=\"padding-left: 30px\"><a href=\"https://musicbrainz.org/artist/%1\">%2</a></td></tr>")).arg(aId).arg(mWebDownloader->artist()));
+        foreach(QString alId, mWebDownloader->data()){
+            text.append(QString("<tr><td style=\"padding-left: 30px\">Album</td><td style=\"padding-left: 30px\"><a href=\"https://musicbrainz.org/release-group/%1\">%2</a></td></tr>").arg(alId).arg(mWebDownloader->album()));
+        }
+        text.append("</table>");
+        const QMap<QString, QString> other = mWebDownloader->otherData();
+        text.append(QString(tr("<b>All Albums (%1):</b><ul>")).arg(QString::number(other.count())));
+        QStringList albums = other.values();
+        std::sort(albums.begin(), albums.end());
+        foreach(QString a, albums){
+            QString id = other.key(a);
+            text.append(QString("<li><a href=\"https://musicbrainz.org/release-group/%1\">%2</a></li>").arg(id).arg(a));
+        }
+        text.append("</ul>");
+    }else{
+        text.append(QString(tr("<b>Musicbrainz: No match!</b><br/>")));
+        const QMap<QString, QString> alt = mWebDownloader->alternateArtists();
+        if(!alt.isEmpty()){
+            text.append(QString(tr("<b>Guesses:</b><ul>")));
+            for(QMap<QString, QString>::const_iterator it = alt.constBegin(); it != alt.constEnd(); ++it){
+                text.append(QString("<li><a href=\"https://musicbrainz.org/artist/%1\">%2</a></li>").arg(it.key()).arg(it.value()));
+            }
+            text.append("</ul>");
+        }
     }
-    text.append("</ul>");
     mLeftTE->setText(text);
 }
 
-- 
cgit v1.2.3-70-g09d2