From 6a60dd9a73cf336a67fdce4f8e067953c765fad9 Mon Sep 17 00:00:00 2001 From: Arno Date: Sat, 9 Nov 2024 13:17:26 +0100 Subject: Fix handling of QCompleter in SmInputDialog setCompleter() assumed that QLineEdit always had a valid completer and schedule it for later deletion. This caused random crashes when there was no deleter. So make sure that mLE always a valid deleter and set the model instead of a new completer. --- moviepropertiesdialog.cpp | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) (limited to 'moviepropertiesdialog.cpp') diff --git a/moviepropertiesdialog.cpp b/moviepropertiesdialog.cpp index 4042d36..0361681 100644 --- a/moviepropertiesdialog.cpp +++ b/moviepropertiesdialog.cpp @@ -182,15 +182,13 @@ void MoviePropertiesDialog::init(int seriesPartsId){ while(allActorsQ.next()){ actorNames << allActorsQ.value(0).toString(); } - QCompleter *actorCompleter = new QCompleter(actorNames, mActorDlg); - mActorDlg->setCompleter(actorCompleter); + mActorDlg->setCompleterModel(actorNames); QStringList genreNames; QSqlQuery allGenresQ("SELECT tgenrename FROM genres", db); while(allGenresQ.next()){ genreNames << allGenresQ.value(0).toString(); } - QCompleter *genreCompleter = new QCompleter(genreNames, mGenreDlg); - mGenreDlg->setCompleter(genreCompleter); + mGenreDlg->setCompleterModel(genreNames); } void MoviePropertiesDialog::addItem(SmInputDialog *dlg, QStandardItemModel *model, QIcon icon){ -- cgit v1.2.3-70-g09d2