From 277668d6b3e240c28dd10481844bba657d3e7cb2 Mon Sep 17 00:00:00 2001 From: Arno Date: Sun, 9 Dec 2018 05:18:35 +0100 Subject: Fix clang warnings in FileWidget use nullptr instead of 0, and add a static_cast to document that we don't need floating point. QVariant::toLongLong() doesn't work with 1234.1234. --- filewidget.cpp | 6 +++--- filewidget.h | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/filewidget.cpp b/filewidget.cpp index 6294487..c863556 100644 --- a/filewidget.cpp +++ b/filewidget.cpp @@ -48,7 +48,7 @@ #include "viewer.h" #include "searchdialog.h" -FileWidget::FileWidget(QWidget *parent) : QWidget(parent), mCopyToMenu(0) { +FileWidget::FileWidget(QWidget *parent) : QWidget(parent), mCopyToMenu(nullptr) { mFileCopier = new FileCopier(this); mFileCache.setMaxCost(500); readCache(); @@ -122,7 +122,7 @@ void FileWidget::setupGui(){ mOrignDlg = new OriginDialog(this); connect(mOrignDlg, &OriginDialog::statusMessage, this, &FileWidget::statusMessage); connect(mOrignDlg, &OriginDialog::refreshNeeded, this, &FileWidget::gatherData); - mSearchDlg = new SearchDialog(this, 0); + mSearchDlg = new SearchDialog(this, nullptr); mMenuBar = new QMenuBar; mToolBar = new QToolBar; mToolBar->setIconSize(QSize(16, 16)); @@ -312,7 +312,7 @@ void FileWidget::gatherData(){ QJsonDocument jDoc = Helper::ffpmegData(fi.absoluteFilePath()); QJsonObject jObj = jDoc.object(); QJsonValue durationV = jObj["format"].toObject()["duration"]; - seconds = durationV.toVariant().toDouble(); + seconds = static_cast(durationV.toVariant().toDouble()); dur = Helper::Duration(seconds); duration = dur.toString(); }else if(fi.isDir()){ diff --git a/filewidget.h b/filewidget.h index f9b5af3..589283d 100644 --- a/filewidget.h +++ b/filewidget.h @@ -37,7 +37,7 @@ class FileWidget : public QWidget { enum { ColumnCount = 7 }; enum Columns { IconColumn = 0, NameColumn = 1, CopiedColumn = 2, MimeColumn = 3, DurationColumn = 4, SizeColumn = 5, Md5Column = 6 }; enum FileAction { Copy, Cut, Paste }; - explicit FileWidget(QWidget *parent = 0); + explicit FileWidget(QWidget *parent = nullptr); QTreeView *fileView() { return mFileView; } QMenuBar *menuBar() { return mMenuBar; } QToolBar *toolBar() { return mToolBar; } -- cgit v1.2.3-70-g09d2