From 980f94e493c349c6c86f1b3d05753ce3cfba38d8 Mon Sep 17 00:00:00 2001 From: Arno Date: Sat, 23 Nov 2019 15:53:37 +0100 Subject: Fix race in updateCopying If the storage is fast enough, passing a bool to updateCopying does not suffice. Then the SIGNAL with inProgress == true could arrive *after* the work is already done, leaving the copy indicator in an inconsitent state. So check the QThread directly by ->isRunning() instead of passing a bool. --- filecopier.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'filecopier.h') diff --git a/filecopier.h b/filecopier.h index 8836749..36f0d6c 100644 --- a/filecopier.h +++ b/filecopier.h @@ -15,7 +15,7 @@ class FileCopier : public QThread { signals: void message(const QString &msg); - void copying(bool copying, const QString &msg); + void copying(const QString &msg); private: QHash mJobs; -- cgit v1.2.3-70-g09d2