Make it run with Qt6

This is a huge commit. Changes:
* Obviously, make it compile
* Make it run (only scarcely tested)
* get rid of most of clang's warnings

Let's see what surprises are in store...

1 files changed, 5 insertions, 5 deletions

diff --git a/searchdialog.cpp b/searchdialog.cpp
index 788c468..87a279e 100644
--- a/searchdialog.cpp
+++ b/searchdialog.cpp
@@ -44,7 +44,7 @@ FilenamesAndMetadata::FilenamesAndMetadata(QWidget *parent, Qt::WindowFlags flag
     connect(doSearchA, &QAction::triggered, this, &FilenamesAndMetadata::search);
     searchTB->addAction(doSearchA);
     QAction *clearSearchA= new QAction(Helper::icon(Qt::transparent, qApp->palette().color(QPalette::Text), QChar(0x2694), true, false), tr("Clear"), this);
-    connect(clearSearchA, &QAction::triggered, [=] { mSearch->clear(); });
+    connect(clearSearchA, &QAction::triggered, this, [=] { mSearch->clear(); });
     searchTB->addAction(clearSearchA);
     QHBoxLayout *topLayout = new QHBoxLayout;
     topLayout->addWidget(l1);
@@ -146,7 +146,7 @@ void FilenamesAndMetadata::search(){
 void FilenamesAndMetadata::appendChild(QVariant id, QVariant subject, QVariant name, QVariant sub, SmTreeItem *parent){
     QString match;
     if(!sub.toString().isEmpty()){
-        match = QString("%1 - %2").arg(name.toString()).arg(sub.toString());
+        match = QString("%1 - %2").arg(name.toString(), sub.toString());
     }else{
         match = name.toString();
     }
@@ -173,7 +173,7 @@ ActorsAndMore::ActorsAndMore(QWidget *parent, Qt::WindowFlags flags) : QWidget(p
     connect(doSearchA, &QAction::triggered, this, &ActorsAndMore::doSearch);
     searchTB->addAction(doSearchA);
     QAction *clearSearchA= new QAction(Helper::icon(Qt::transparent, qApp->palette().color(QPalette::Text), QChar(0x2694), true, false), tr("Clear"), this);
-    connect(clearSearchA, &QAction::triggered, [=] { mSearch->clear(); });
+    connect(clearSearchA, &QAction::triggered, this, [=] { mSearch->clear(); });
     searchTB->addAction(clearSearchA);
     QHBoxLayout *topHBL = new QHBoxLayout;
     topHBL->addWidget(typeL);
@@ -327,7 +327,7 @@ void ActorsAndMore::getGenresForActor(QStandardItem *actorItem){
         res << genreQ.value(0).toString();
     }
     if(!res.isEmpty()){
-        for(QString g : res){
+        for(const auto &g : res){
             QStandardItem *cur = new QStandardItem(g);
             cur->setIcon(icon);
             cur->setEditable(false);
@@ -477,7 +477,7 @@ void ActorsAndMore::getDataForActor(QModelIndex cur){
                 if(sub.isEmpty()){
                     curDisp = QString("%1 - <no sub/part>").arg(displayQ.value(0).toString());
                 }else{
-                    curDisp = QString("%1 - %2").arg(displayQ.value(0).toString()).arg(sub);
+                    curDisp = QString("%1 - %2").arg(displayQ.value(0).toString(), sub);
                 }
             }
             QStandardItem *cur = new QStandardItem(curDisp);