Fix handling of QCompleter in SmInputDialog

setCompleter() assumed that QLineEdit always had a valid completer and
schedule it for later deletion. This caused random crashes when there
was no deleter. So make sure that mLE always a valid deleter and set the
model instead of a new completer.

1 files changed, 5 insertions, 3 deletions

diff --git a/sminputdialog.cpp b/sminputdialog.cpp
index f078141..ecd43c2 100644
--- a/sminputdialog.cpp
+++ b/sminputdialog.cpp
@@ -3,12 +3,15 @@
 #include <QCompleter>
 #include <QHBoxLayout>
 #include <QVBoxLayout>
+#include <QStringListModel>
 
 #include "sminputdialog.h"
 
 SmInputDialog::SmInputDialog(const QString &label, QWidget *parent) : QDialog(parent){
     QLabel *thisL = new QLabel(label);
     mLE = new QLineEdit;
+    mCompleter = new QCompleter(this);
+    mLE->setCompleter(mCompleter);
     QPushButton *cancelPB = new QPushButton(tr("Cancel"));
     connect(cancelPB, &QPushButton::clicked, this, &SmInputDialog::reject);
     QPushButton *acceptPB = new QPushButton(tr("OK"));
@@ -30,7 +33,6 @@ void SmInputDialog::setText(QString &text){
     mLE->setText(text);
 }
 
-void SmInputDialog::setCompleter(QCompleter *completer){
-    mLE->completer()->deleteLater();
-    mLE->setCompleter(completer);
+void SmInputDialog::setCompleterModel(const QStringList &model){
+    mCompleter->setModel(new QStringListModel(model));
 }