summaryrefslogtreecommitdiffstats
path: root/filecopier.h
diff options
context:
space:
mode:
authorArno <arno@disconnect.de>2019-11-23 15:53:37 +0100
committerArno <arno@disconnect.de>2019-11-23 15:53:37 +0100
commit980f94e493c349c6c86f1b3d05753ce3cfba38d8 (patch)
treef5267e2fc7ad9c58668ee62834e8e006c3bf32bd /filecopier.h
parent30d61398cbb8a2694b648d3fceb119fbeaf756a1 (diff)
downloadShemovCleaner-980f94e493c349c6c86f1b3d05753ce3cfba38d8.tar.gz
ShemovCleaner-980f94e493c349c6c86f1b3d05753ce3cfba38d8.tar.bz2
ShemovCleaner-980f94e493c349c6c86f1b3d05753ce3cfba38d8.zip
Fix race in updateCopying
If the storage is fast enough, passing a bool to updateCopying does not suffice. Then the SIGNAL with inProgress == true could arrive *after* the work is already done, leaving the copy indicator in an inconsitent state. So check the QThread directly by ->isRunning() instead of passing a bool.
Diffstat (limited to 'filecopier.h')
-rw-r--r--filecopier.h2
1 files changed, 1 insertions, 1 deletions
diff --git a/filecopier.h b/filecopier.h
index 8836749..36f0d6c 100644
--- a/filecopier.h
+++ b/filecopier.h
@@ -15,7 +15,7 @@ class FileCopier : public QThread {
signals:
void message(const QString &msg);
- void copying(bool copying, const QString &msg);
+ void copying(const QString &msg);
private:
QHash<QString, QString> mJobs;